Merge pull request #48 from Kochava/remove-container-registry2

fix: remove container registry pushes
Kochava · Feb 26, 2025 · d8a0940 · d8a0940
2 parents d96a1b8 + cf4cc87
commit d8a0940
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 104 deletions.
diff --git a/.github/workflows/base_app_release.yml b/.github/workflows/base_app_release.yml
@@ -22,13 +22,6 @@ on:
       ARTIFACT_REGISTRY_JSON_KEY:
         description: 'Key for publishing to Artifact Registry'
         required: false
-      # Container Registry arguements
-      CONTAINER_REGISTRY:
-        description: 'Container Registry address to which to publish (leave blank to not publish)'
-        required: false
-      CONTAINER_REGISTRY_JSON_KEY:
-        description: 'Key for publishing to Container Registry'
-        required: false
 
 jobs:
   push:
@@ -52,21 +45,13 @@ jobs:
         if: ${{ env.ARTIFACT_REGISTRY }}
         run: |
           echo "ARTIFACT_REGISTRY_IMAGE_NAME=${{ secrets.ARTIFACT_REGISTRY }}/${{ github.repository }}" >> $GITHUB_ENV
-      # Make the docker fields for Container Registry if we're pushing to it.
-      - name: Construct Container Registry fields
-        env:
-          CONTAINER_REGISTRY: ${{ secrets.CONTAINER_REGISTRY }}
-        if: ${{ env.CONTAINER_REGISTRY }}
-        run: |
-          echo "CONTAINER_REGISTRY_IMAGE_NAME=${{ secrets.CONTAINER_REGISTRY }}/${{ steps.parse_repo_name.outputs.repo_name }}" >> $GITHUB_ENV
       # Create docker image meta data. Docker tags include the Git tag itself and the sematic version parsing of that tag if possible.
       - name: Docker release meta
         id: release
         uses: docker/metadata-action@v4
         with:
           images: |
             ${{ env.ARTIFACT_REGISTRY_IMAGE_NAME }}
-            ${{ env.CONTAINER_REGISTRY_IMAGE_NAME }}
           flavor: |
             latest=false
           tags: |
@@ -82,16 +67,6 @@ jobs:
           registry: ${{ secrets.ARTIFACT_REGISTRY }}
           username: _json_key
           password: ${{ secrets.ARTIFACT_REGISTRY_JSON_KEY }}
-      # Login to Container Registry if we're pushing to it.
-      - name: Login to Container Registry
-        env:
-          CONTAINER_REGISTRY_JSON_KEY: ${{ secrets.CONTAINER_REGISTRY_JSON_KEY }}
-        if: ${{ env.CONTAINER_REGISTRY_JSON_KEY }}
-        uses: docker/login-action@v2
-        with:
-          registry: ${{ secrets.CONTAINER_REGISTRY }}
-          username: _json_key
-          password: ${{ secrets.CONTAINER_REGISTRY_JSON_KEY }}
       # Setup QEMU needed to build arm64 images.
       - name: Setup QEMU
         uses: docker/setup-qemu-action@v2
@@ -100,7 +75,7 @@ jobs:
         id: buildx
         uses: docker/setup-buildx-action@v2
       # Build and push the image.
-      - name: Build and Push to Artifact Registry and Container Registry
+      - name: Build and Push to Artifact Registry
         uses: docker/build-push-action@v3
         with:
           push: true

diff --git a/.github/workflows/go_app_release.yml b/.github/workflows/go_app_release.yml
@@ -26,13 +26,6 @@ on:
       ARTIFACT_REGISTRY_JSON_KEY:
         description: 'Key for publishing to Artifact Registry'
         required: false
-      # Container Registry arguements
-      CONTAINER_REGISTRY:
-        description: 'Container Registry address to which to publish (leave blank to not publish)'
-        required: false
-      CONTAINER_REGISTRY_JSON_KEY:
-        description: 'Key for publishing to Container Registry'
-        required: false
 
 env:
   GOPRIVATE: ${{ inputs.GOPRIVATE }}
@@ -72,21 +65,13 @@ jobs:
         if: ${{ env.ARTIFACT_REGISTRY }}
         run: |
           echo "ARTIFACT_REGISTRY_IMAGE_NAME=${{ secrets.ARTIFACT_REGISTRY }}/${{ github.repository }}" >> $GITHUB_ENV
-      # Make the docker fields for Container Registry if we're pushing to it.
-      - name: Construct Container Registry fields
-        env:
-          CONTAINER_REGISTRY: ${{ secrets.CONTAINER_REGISTRY }}
-        if: ${{ env.CONTAINER_REGISTRY }}
-        run: |
-          echo "CONTAINER_REGISTRY_IMAGE_NAME=${{ secrets.CONTAINER_REGISTRY }}/${{ steps.parse_repo_name.outputs.repo_name }}" >> $GITHUB_ENV
       # Create docker image meta data. Docker tags include the Git tag itself and the sematic version parsing of that tag if possible.
       - name: Docker release meta
         id: release
         uses: docker/metadata-action@v4
         with:
           images: |
             ${{ env.ARTIFACT_REGISTRY_IMAGE_NAME }}
-            ${{ env.CONTAINER_REGISTRY_IMAGE_NAME }}
           flavor: |
             latest=false
           tags: |
@@ -102,16 +87,6 @@ jobs:
           registry: ${{ secrets.ARTIFACT_REGISTRY }}
           username: _json_key
           password: ${{ secrets.ARTIFACT_REGISTRY_JSON_KEY }}
-      # Login to Container Registry if we're pushing to it.
-      - name: Login to Container Registry
-        env:
-          CONTAINER_REGISTRY_JSON_KEY: ${{ secrets.CONTAINER_REGISTRY_JSON_KEY }}
-        if: ${{ env.CONTAINER_REGISTRY_JSON_KEY }}
-        uses: docker/login-action@v2
-        with:
-          registry: ${{ secrets.CONTAINER_REGISTRY }}
-          username: _json_key
-          password: ${{ secrets.CONTAINER_REGISTRY_JSON_KEY }}
       # Setup QEMU needed to build arm64 images.
       - name: Setup QEMU
         uses: docker/setup-qemu-action@v2
@@ -120,7 +95,7 @@ jobs:
         id: buildx
         uses: docker/setup-buildx-action@v2
       # Build and push the image.
-      - name: Build and Push to Artifact Registry and Container Registry
+      - name: Build and Push to Artifact Registry
         uses: docker/build-push-action@v3
         with:
           push: true

diff --git a/.github/workflows/gradle_jvm_app_release.yml b/.github/workflows/gradle_jvm_app_release.yml
@@ -26,13 +26,6 @@ on:
       ARTIFACT_REGISTRY_JSON_KEY:
         description: 'Key for publishing to Artifact Registry'
         required: false
-      # Container Registry arguements
-      CONTAINER_REGISTRY:
-        description: 'Container Registry address to which to publish (leave blank to not publish)'
-        required: false
-      CONTAINER_REGISTRY_JSON_KEY:
-        description: 'Key for publishing to Container Registry'
-        required: false
 
 env:
   GOPRIVATE: ${{ inputs.GOPRIVATE }}
@@ -66,21 +59,13 @@ jobs:
         if: ${{ env.ARTIFACT_REGISTRY }}
         run: |
           echo "ARTIFACT_REGISTRY_IMAGE_NAME=${{ secrets.ARTIFACT_REGISTRY }}/${{ github.repository }}" >> $GITHUB_ENV
-      # Make the docker fields for Container Registry if we're pushing to it.
-      - name: Construct Container Registry fields
-        env:
-          CONTAINER_REGISTRY: ${{ secrets.CONTAINER_REGISTRY }}
-        if: ${{ env.CONTAINER_REGISTRY }}
-        run: |
-          echo "CONTAINER_REGISTRY_IMAGE_NAME=${{ secrets.CONTAINER_REGISTRY }}/${{ steps.parse_repo_name.outputs.repo_name }}" >> $GITHUB_ENV
       # Create docker image meta data. Docker tags include the Git tag itself and the sematic version parsing of that tag if possible.
       - name: Docker release meta
         id: release
         uses: docker/metadata-action@v4
         with:
           images: |
             ${{ env.ARTIFACT_REGISTRY_IMAGE_NAME }}
-            ${{ env.CONTAINER_REGISTRY_IMAGE_NAME }}
           flavor: |
             latest=false
           tags: |
@@ -96,16 +81,6 @@ jobs:
           registry: ${{ secrets.ARTIFACT_REGISTRY }}
           username: _json_key
           password: ${{ secrets.ARTIFACT_REGISTRY_JSON_KEY }}
-      # Login to Container Registry if we're pushing to it.
-      - name: Login to Container Registry
-        env:
-          CONTAINER_REGISTRY_JSON_KEY: ${{ secrets.CONTAINER_REGISTRY_JSON_KEY }}
-        if: ${{ env.CONTAINER_REGISTRY_JSON_KEY }}
-        uses: docker/login-action@v2
-        with:
-          registry: ${{ secrets.CONTAINER_REGISTRY }}
-          username: _json_key
-          password: ${{ secrets.CONTAINER_REGISTRY_JSON_KEY }}
       # Setup QEMU needed to build arm64 images.
       - name: Setup QEMU
         uses: docker/setup-qemu-action@v2
@@ -114,7 +89,7 @@ jobs:
         id: buildx
         uses: docker/setup-buildx-action@v2
       # Build and push the image.
-      - name: Build and Push to Artifact Registry and Container Registry
+      - name: Build and Push to Artifact Registry
         uses: docker/build-push-action@v3
         with:
           push: true

diff --git a/.github/workflows/ruby_app_release.yml b/.github/workflows/ruby_app_release.yml
@@ -13,13 +13,6 @@ on:
       ARTIFACT_REGISTRY_JSON_KEY:
         description: 'Key for publishing to Artifact Registry'
         required: false
-      # Container Registry arguments
-      CONTAINER_REGISTRY:
-        description: 'Container Registry address to which to publish (leave blank to not publish)'
-        required: false
-      CONTAINER_REGISTRY_JSON_KEY:
-        description: 'Key for publishing to Container Registry'
-        required: false
 
 jobs:
   push:
@@ -42,21 +35,13 @@ jobs:
         if: ${{ env.ARTIFACT_REGISTRY }}
         run: |
           echo "ARTIFACT_REGISTRY_IMAGE_NAME=${{ secrets.ARTIFACT_REGISTRY }}/${{ github.repository }}" >> $GITHUB_ENV
-      # Make the docker fields for Container Registry if we're pushing to it.
-      - name: Construct Container Registry fields
-        env:
-          CONTAINER_REGISTRY: ${{ secrets.CONTAINER_REGISTRY }}
-        if: ${{ env.CONTAINER_REGISTRY }}
-        run: |
-          echo "CONTAINER_REGISTRY_IMAGE_NAME=${{ secrets.CONTAINER_REGISTRY }}/${{ steps.parse_repo_name.outputs.repo_name }}" >> $GITHUB_ENV
       # Create docker image meta data. Docker tags include the Git tag itself and the sematic version parsing of that tag if possible.
       - name: Docker release meta
         id: release
         uses: docker/metadata-action@v4
         with:
           images: |
             ${{ env.ARTIFACT_REGISTRY_IMAGE_NAME }}
-            ${{ env.CONTAINER_REGISTRY_IMAGE_NAME }}
           flavor: |
             latest=false
           tags: |
@@ -72,22 +57,12 @@ jobs:
           registry: ${{ secrets.ARTIFACT_REGISTRY }}
           username: _json_key
           password: ${{ secrets.ARTIFACT_REGISTRY_JSON_KEY }}
-      # Login to Container Registry if we're pushing to it.
-      - name: Login to Container Registry
-        env:
-          CONTAINER_REGISTRY_JSON_KEY: ${{ secrets.CONTAINER_REGISTRY_JSON_KEY }}
-        if: ${{ env.CONTAINER_REGISTRY_JSON_KEY }}
-        uses: docker/login-action@v2
-        with:
-          registry: ${{ secrets.CONTAINER_REGISTRY }}
-          username: _json_key
-          password: ${{ secrets.CONTAINER_REGISTRY_JSON_KEY }}
       # Setup Docker builder needed to build multi-architectural images.
       - name: Setup Docker Buildx
         id: buildx
         uses: docker/setup-buildx-action@v2
       # Build and push the image.
-      - name: Build and Push to Artifact Registry and Container Registry
+      - name: Build and Push to Artifact Registry
         uses: docker/build-push-action@v3
         with:
           push: true