Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: limit permissions of GITHUB_TOKEN and add actionlint #1227

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jan 21, 2025

What this PR does / why we need it:

Release job has been failing: https://github.com/Kong/charts/actions/runs/12887167527

As part of this PR:

  • GitHub actions' token for actions has been upgraded to write access ( to create releases )
  • workflow wide permissions have been limited to contents: read (this PR's changes)
  • actionlint has been added to lint actions' files on CI

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@pmalek pmalek added the area/ci label Jan 21, 2025
@pmalek pmalek self-assigned this Jan 21, 2025
@pmalek pmalek marked this pull request as ready for review January 21, 2025 13:06
@pmalek pmalek requested a review from a team as a code owner January 21, 2025 13:06
@pmalek pmalek force-pushed the gha-permissions-and-actionlint branch from 2ee9611 to d4ee00e Compare January 21, 2025 13:07
@pmalek pmalek enabled auto-merge (squash) January 21, 2025 13:07
@pmalek pmalek disabled auto-merge January 21, 2025 13:11
@pmalek pmalek merged commit 4168a95 into main Jan 21, 2025
33 checks passed
@pmalek pmalek deleted the gha-permissions-and-actionlint branch January 21, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants