Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kgo): fix ports.dataplane.gateway-operator.konghq.com ValidatingAdmissionPolicy rules #1229

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix(kgo): fix ports.dataplane.gateway-operator.konghq.com ValidatingAdmissionPolicy rules #1229

merged 1 commit into from
Jan 22, 2025

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jan 21, 2025 •
edited
Loading

What this PR does / why we need it:

ValidatingAdmissionPolicy added in #1215 had incomplete rules causing:

resourceVersion should not be set on objects to be created

errors. This PR fixes it.

Related change in KGO: Kong/gateway-operator#1067

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@pmalek pmalek self-assigned this Jan 21, 2025
@pmalek pmalek force-pushed the fix-validating-admission-policy-dataplane-ports branch from 726c98b to 40013a4 Compare January 21, 2025 18:41
@pmalek pmalek marked this pull request as ready for review January 22, 2025 08:27
@pmalek pmalek requested a review from a team as a code owner January 22, 2025 08:27
@pmalek pmalek requested a review from czeslavo January 22, 2025 08:27
@pmalek pmalek force-pushed the fix-validating-admission-policy-dataplane-ports branch from 40013a4 to c317274 Compare January 22, 2025 08:57
@pmalek pmalek force-pushed the fix-validating-admission-policy-dataplane-ports branch from c317274 to e68cb02 Compare January 22, 2025 08:58
@pmalek pmalek enabled auto-merge (squash) January 22, 2025 09:06
@pmalek pmalek merged commit f931c9a into main Jan 22, 2025
34 checks passed
@pmalek pmalek deleted the fix-validating-admission-policy-dataplane-ports branch January 22, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czeslavo czeslavo czeslavo approved these changes

Assignees

@pmalek pmalek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmalek @czeslavo