Improve query string normalization and add hooks system#114
Conversation
ad-git
commented
Aug 12, 2016
- Improve query string normalization to RFC 3986 and avoid truncation if query has duplicate parameter with same name.
- Additional hook system useful for debug
|
hey @ad-git sorry for missing this PR!!! looks great, but can you please add some tests + update the documentation? thank you. |
|
Does this also solve the problem when I am trying to use a query string parameter with a + in it? I want to use 'starttimetime' with value '2017-04-05T11:48:59+02:00'. Eventually this is being sent with a space. I debugged it and this is caused by the Request::getArrayFromQuerystring function that uses parse_str. This decodes the + sign to a space. |
|
Hello, Will this pull request be merged any time soon ? I have a similar issues when sending multiple tags (eg. someUrl?tags[]=php&tags[]=unirest). Unirest strips the second parameters resulting in someUrl?tags[]=php. Thanks! |
|
Andrea seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |