Skip to content

Because it is a numeric port and it can not be received as an array #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peymansheybani wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Because it is a numeric port and it can not be received as an array #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Unirest/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,12 +555,16 @@ private static function encodeUrl($url)
$query = '?' . http_build_query(self::getArrayFromQuerystring($query));
}

// Because it is a numeric port and it can not be received as an array
// And you have to turn it into a string
// $port[0] has it error
$port = "$port";

if ($port && $port[0] !== ':') {
$port = ':' . $port;
}

$result = $scheme . $host . $port . $path . $query;
return $result;
return $scheme . $host . $port . $path . $query;
}

private static function getHeaderString($key, $val)
Expand Down