Skip to content

Add missing fields to STS PVC claim #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

Add missing fields to STS PVC claim #177

merged 1 commit into from
Aug 22, 2025

Conversation

@alekhrycaiko
Copy link
Contributor

@alekhrycaiko alekhrycaiko commented Aug 21, 2025 •
edited
Loading

What this PR does / why we need it

  • Adds missing fields from the STS which are usually required in a persistent volume claim. Without adding these, the API server will need to correct this. Tools such as ArgoCD will also notice the mutation and flag resources out of sync, as there's something being modified between Git/API server here.

It'd be better for end users if all fields are included and we can avoid workarounds in our GitOps systems.

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped

@alekhrycaiko alekhrycaiko force-pushed the fix-pvc-claim-templates branch from 36c3522 to e5d5039 Compare August 21, 2025 18:53
@alekhrycaiko alekhrycaiko force-pushed the fix-pvc-claim-templates branch from e5d5039 to 6196db0 Compare August 21, 2025 18:55
@KongZ KongZ merged commit 1dc2f4c into KongZ:main Aug 22, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KongZ KongZ KongZ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing PVC fields in STS causing out of sync in Argo

2 participants

@alekhrycaiko @KongZ