Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 添加康熙字典体原籍字体。 #86

Open
wants to merge 1 commit into
base: branch
Choose a base branch
from

Conversation

PrinOrange
Copy link
Contributor

@PrinOrange PrinOrange commented Feb 20, 2025

添加康熙字典体原籍字体。

Summary by Sourcery

Adds the Kangxi Dictionary Origin font to the Chinese Web Fonts project, providing a resource for classical Chinese typesetting.

New Features:

  • Adds the Kangxi Dictionary Origin font, a scanned font suitable for classical Chinese typesetting, to the Chinese Web Fonts project.

Documentation:

  • Includes instructions on how to use the font via CDN or by installing the npm package.

Copy link

netlify bot commented Feb 20, 2025

‼️ Deploy request for chinese-font rejected.

Name Link
🔨 Latest commit 2cd254e

Copy link

sourcery-ai bot commented Feb 20, 2025

Reviewer's Guide by Sourcery

This pull request adds the 'Kangxi Dictionary Origin' font to the Chinese Web Fonts project. It includes the necessary files and configurations to allow users to easily use the font via CDN or by installing the package from NPM. The font is specifically designed for classical Chinese texts and does not support simplified characters.

Class diagram for Kangxi Dictionary Origin package

classDiagram
    class KangxiDictionaryOrigin {
        +name: string
        +version: string
        +description: string
        +main: string
        +publishConfig: object
        +keywords: string[]
        +author: string
        +license: string
        +homepage: string
        +repository: object
        +dependencies: object
    }
    note for KangxiDictionaryOrigin "Represents the package.json structure for the Kangxi Dictionary Origin font package."
Loading

File-Level Changes

Change Details Files
Added documentation for the 'Kangxi Dictionary Origin' font package.
  • Introduced a README file with information about the font, its usage, and licensing.
  • Provided instructions for using the font via CDN and NPM.
packages/KangxiDictionaryOrigin/README.md
Created a package.json file for the 'Kangxi Dictionary Origin' font.
  • Defined the package name, version, and description.
  • Configured the package for public access and specified keywords.
  • Added author, license, homepage, and repository information.
  • Included dependencies (none in this case).
packages/KangxiDictionaryOrigin/package.json
Added .npmignore file to exclude unnecessary files from the published package.
  • The file is currently empty, indicating that all files in the package should be included.
packages/KangxiDictionaryOrigin/.npmignore

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PrinOrange - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a build script to the package.json to automate the creation of the CSS files.
  • It would be helpful to include a license file for the font itself, in addition to the project's MIT license.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.


[官网](https://chinese-font.netlify.app)

中文网字项目是用于将中文字体切割并放置在 NPM 进行快速部署的项目。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (typo): Use lowercase for "npm".

Suggested change
中文网字项目是用于将中文字体切割并放置在 NPM 进行快速部署的项目。
中文网字项目是用于将中文字体切割并放置在 npm 进行快速部署的项目。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant