-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 添加康熙字典体原籍字体。 #86
base: branch
Are you sure you want to change the base?
feat: 添加康熙字典体原籍字体。 #86
Conversation
|
Name | Link |
---|---|
🔨 Latest commit | 2cd254e |
Reviewer's Guide by SourceryThis pull request adds the 'Kangxi Dictionary Origin' font to the Chinese Web Fonts project. It includes the necessary files and configurations to allow users to easily use the font via CDN or by installing the package from NPM. The font is specifically designed for classical Chinese texts and does not support simplified characters. Class diagram for Kangxi Dictionary Origin packageclassDiagram
class KangxiDictionaryOrigin {
+name: string
+version: string
+description: string
+main: string
+publishConfig: object
+keywords: string[]
+author: string
+license: string
+homepage: string
+repository: object
+dependencies: object
}
note for KangxiDictionaryOrigin "Represents the package.json structure for the Kangxi Dictionary Origin font package."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @PrinOrange - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a build script to the package.json to automate the creation of the CSS files.
- It would be helpful to include a license file for the font itself, in addition to the project's MIT license.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
||
[官网](https://chinese-font.netlify.app) | ||
|
||
中文网字项目是用于将中文字体切割并放置在 NPM 进行快速部署的项目。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (typo): Use lowercase for "npm".
中文网字项目是用于将中文字体切割并放置在 NPM 进行快速部署的项目。 | |
中文网字项目是用于将中文字体切割并放置在 npm 进行快速部署的项目。 |
添加康熙字典体原籍字体。
Summary by Sourcery
Adds the Kangxi Dictionary Origin font to the Chinese Web Fonts project, providing a resource for classical Chinese typesetting.
New Features:
Documentation: