Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compiler plugin] Support more GroupBy shortcuts #1055

Merged
merged 4 commits into from
Feb 13, 2025
Merged

[Compiler plugin] Support more GroupBy shortcuts #1055

merged 4 commits into from
Feb 13, 2025

Conversation

koperagen
Copy link
Collaborator

Now these are supported:

GroupBy.[minOf | maxOf]
GroupBy.[first | last | maxBy | minBy].into(columName) 
GroupBy.count

@koperagen koperagen added the Compiler plugin Anything related to the DataFrame Compiler Plugin label Feb 10, 2025
@koperagen koperagen added this to the 0.16 milestone Feb 10, 2025
@koperagen koperagen self-assigned this Feb 10, 2025
Jolanrensen
Jolanrensen approved these changes Feb 11, 2025
View reviewed changes
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/concat.kt
@@ -42,6 +42,15 @@ public fun <T, G> GroupBy<T, G>.concat(): DataFrame<G> = groups.concat()

// endregion

// region ReducedGroupBy

public fun <T, G> ReducedGroupBy<T, G>.concat(): DataFrame<G> =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this used anywhere? If I look for usages I cannot find any

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we just need a junit test, we can do it later, just make sure it's in our excel sheet in the right place after moving it here :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it was overlooked because it was not in a good place! I will likely revisit it, because sometimes it can produce empty dataframe, need to check that with compiler plugin we'd have a reasonable exception in this case

plugins/kotlin-dataframe/testData/box/groupBy_count.kt Show resolved Hide resolved
plugins/kotlin-dataframe/testData/box/groupBy_maxOfMinOf.kt Show resolved Hide resolved
@koperagen koperagen merged commit a626961 into master Feb 13, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolanrensen Jolanrensen Jolanrensen approved these changes

Assignees

@koperagen koperagen

Labels
Compiler plugin Anything related to the DataFrame Compiler Plugin
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.
2 participants
@koperagen @Jolanrensen