Sum statistics and aggregator improvements #1103
Merged
+334
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/sum.kt
Jolanrensen
force-pushed
the
sum
branch
3 times, most recently
from
f2e7a32 to
5ebabf9
Compare
…can now return `null`, so we can give helpful errors from the aggregator
Jolanrensen
requested review from
AndreiKingsley
and removed request for
AndreiKingsley
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #961
sumimplementation, based on the table at ☂ Statistics streamlining #961sumoverloads so they always return the correct type based on the tableaggregateOfRowmeanandsumwill now select primitive- or mixed numbers only. This automatically excludes columns with unsupported numbers and in the slight case unsupported numbers end up in a mixed column, we provide a helpful exception.