Improved SQL<->JDBC mapping #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled the dataframe debug mode by default in the gradle.properties file. Updated JDBC type mappings to use more appropriate Kotlin types and improved handling for certain special cases. Adjusted corresponding test cases to align with these changes.
Changed several column type mappings in test cases from Float and Char to Double and String respectively for better compliance with JDBC standards. Adjusted main code to handle BLOB types as ByteArray and refined conditional logic in MariaDb and SQLite converters.
Corrected handling of SQL Array types to properly map them to Kotlin arrays. Updated test cases to include integer array column and verified schema recognition of SQL Array types.
Corrected handling of SQL Array types to properly map them to Kotlin arrays. Introduced a utility function to cast arrays and refactored the read logic to use it. Updated test cases to include various array columns and verified schema recognition of these types.
Enhanced the SQL schema handling to accommodate array types in Postgres and improved support for Blob types in MySQL and MariaDB. Also standardized the use of specific timestamps and fixed data type mappings for schemas.
Optimized code layout in several files, including `mysqlTest.kt`, `readJdbc.kt`, and `postgresH2Test.kt`, for enhanced readability. This includes reformatting function definitions, rearranging import statements, and using concise lambda expressions.
Changed the `kotlin.dataframe.debug` property to `false`, which was previously set to `true`. This adjustment ensures that tests meant for debugging are not mistakenly executed in production environments.
Jolanrensen
requested changes
Sep 16, 2024
dataframe-jdbc/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/readJdbc.kt
Outdated
Show resolved
Hide resolved
dataframe-jdbc/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/readJdbc.kt
Outdated
Show resolved
Hide resolved
dataframe-jdbc/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/readJdbc.kt
Outdated
Show resolved
Hide resolved
dataframe-jdbc/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/readJdbc.kt
Show resolved
Hide resolved
Changed `castArray` to use safe casting and made it private. Improved handling of array element types by checking distinct types and ensuring consistency, with fallback behavior for varying or unknown types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #804 Fixes #701
Closed #859