Skip to content

Added special check for function types in debug mode #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Jolanrensen
Copy link
Collaborator

Fixes failing test in debug mode:

org.jetbrains.kotlinx.dataframe.testSets.person.DataFrameTests.guess column type for type without classifier
java.lang.IllegalArgumentException: Values of ValueColumn 'a' have types '[DataFrameTests$$Lambda$4183/0x000000010140ac40]' which are not compatible given with column type 'kotlin.Function<*>'
  at org.jetbrains.kotlinx.dataframe.impl.columns.DataColumnImpl.<init>(DataColumnImpl.kt:39)

It was caused by recognizing kotlin.Function<*> types explicitly in 10935d2.

I simply added an additional check in the debug mode for functional types, as the check should not fail for this case.

@Jolanrensen Jolanrensen added this to the 0.14.0 milestone Sep 16, 2024
Copy link
Contributor

Generated sources will be updated after merging this PR.
Please inspect the changes in here.

@Jolanrensen Jolanrensen merged commit ac652db into master Sep 16, 2024
4 of 6 checks passed
@Jolanrensen Jolanrensen deleted the debug-mode-function-type-fix branch September 16, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants