ktl-1702 Adjust link style #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpachoo
force-pushed
the
ktl-1702-revamp-links
branch
from
5429fd7 to
e3bfb5a
Compare
nikpachoo
commented
Feb 6, 2025
dokka-subprojects/plugin-base-frontend/src/main/ui-kit/global.scss
Outdated
Show resolved
Hide resolved
berezinant
approved these changes
Feb 7, 2025
dokka-subprojects/plugin-base-frontend/src/main/ui-kit/global.scss
Outdated
Show resolved
Hide resolved
nikpachoo
force-pushed
the
ktl-1702-revamp-links
branch
2 times, most recently
from
a14269f to
4710b97
Compare
nikpachoo
force-pushed
the
ktl-1702-revamp-links
branch
from
4710b97 to
27c1058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/KTL-1702/Dokka-adjust-link-style
To update the links' styles to the expected ones, I changed the global font size to 16px. Without it, the typography will not work as we want it.
Overall view after changes:
In dark mode:
Default state:
Hover state:
Focus state:
Default state in dark mode:
Hover state in dark mode:
Focus state in dark mode:
