KRPC-245 Fix eager configuration resolution warning in Gradle 9.0 - #651
Merged
Conversation
Replace `project.provider { config.get().singleFile }` with
`config.flatMap { it.elements.map { it.single().asFile } }` so that
protocGenKotlinMultiplatformJar, protocGenGrpcKotlinMultiplatformJar,
and bufExecutable configurations are resolved lazily through Gradle's
provider chain instead of during configuration time.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Mr3zee
added
bug
Mr3zee
marked this pull request as ready for review
April 7, 2026 21:39
- CancellationTest.testCancelServer: 30s timeout on native (KRPC-548) - GrpcTimeoutTest short milliseconds: race on macosArm64 (KRPC-549) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subsystem
Gradle Plugin (protoc/buf)
Problem Description
KRPC-245 — Three Gradle configurations (
protocGenKotlinMultiplatformJar,protocGenGrpcKotlinMultiplatformJar,bufExecutable) are resolved during configuration time, producing warnings in Gradle 9.0:This only manifests in user projects (not in the kotlinx-rpc build itself) because internally the protoc-gen jars come from included builds.
Solution
Replace
project.provider { config.get().singleFile }withconfig.flatMap { it.elements.map { ... } }in two sites:pluginJars.kt:jarPathAccessor()— resolvesprotocGenKotlinMultiplatformJarandprotocGenGrpcKotlinMultiplatformJarBufExecTask.kt:registerBufExecTask()— resolvesbufExecutableConfiguration.elementsreturns aProvider<Set<FileSystemLocation>>that Gradle tracks as a proper lazy dependency, deferring resolution to task execution time instead of configuration time.Note
This is a fully autonomous autogenerated PR. No human reviewed the code before submission.
🤖 Generated with Claude Code