KRPC-609 Apple OS min values - #737
Merged
Merged
Conversation
…azel to 8.6.0 in shims
…e_arm64) Xcode clamps the arm64 watchOS device deployment target up to the SDK version (the requested 9.0 is unachievable for that platform), so the strict check failed the gRPC release on watchos_device_arm64. Verify objects against the toolchain's effective minimum instead: probe `clang -target <konan-triple>` to detect a platform clamp, and when clamped expect the SDK version (`xcrun --show-sdk-version`); otherwise enforce the requested minimum strictly. The verify task now reads the target triple from konan.properties. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC/Protobuf Apple
Problem Description
We were not setting minos values for apple binaries and shims
Solution
Set them and autocheck artifacts
Fixes: #721