Merged
Conversation
Signed-off-by: craig <cbrookes@redhat.com>
Signed-off-by: craig <cbrookes@redhat.com>
david-martin
approved these changes
Sep 17, 2024
Member
david-martin
left a comment
david-martin
left a comment
There was a problem hiding this comment.
Thanks @maleck13
I'm happy to merge this as is, and update pending changes in #47 to move the non gateway api resource out to a separate kuadrant folder.
I plan to do a release (0.5.0) after that pr lands. See the description in there for how to include the kuadrant metrics config after that release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a
kuadrant_dnrecord_status_ownersandkuadrant_dnsrecord_statusmetrics which will can be used to see how many dnsrecords there are and how many owners there are. Allowing an alert to be crafted in a multi-instance scenerio to spot hosts with potential orphaned records (IE ones the operator did not get chance to remove for some reason)