Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: clear pods which shardingconfig is not found #27

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

Eikykun
Copy link
Collaborator

@Eikykun Eikykun commented Jan 11, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Delete sharding pods after ShardingConfig deleted

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@Eikykun Eikykun self-assigned this Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (24cb737) 43.14% compared to head (e200574) 42.37%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../shardingconfigserver/shardingconfig_controller.go 0.00% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   43.14%   42.37%   -0.78%     
==========================================
  Files          26       26              
  Lines        2788     2820      +32     
==========================================
- Hits         1203     1195       -8     
- Misses       1479     1517      +38     
- Partials      106      108       +2     
Flag Coverage Δ
unittests 42.37% <0.00%> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikykun Eikykun merged commit 251089b into main Jan 11, 2024
4 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
@Eikykun Eikykun deleted the 240111-fix-shard branch July 10, 2024 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants