Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service unavailable pod should take priority over available when updating #314

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

ColdsteelRail
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.12%. Comparing base (2fa4811) to head (7f4cea1).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../controllers/utils/poddecoration/strategy/types.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   66.08%   66.12%   +0.04%     
==========================================
  Files          79       79              
  Lines        5770     5774       +4     
==========================================
+ Hits         3813     3818       +5     
+ Misses       1596     1595       -1     
  Partials      361      361              
Flag Coverage Δ
unittests 66.12% <25.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoumo zoumo changed the title fix update order fix: service unavailable pod should take priority over available when updating Mar 3, 2025
Copy link
Collaborator

@zoumo zoumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoumo zoumo merged commit 4f85fb5 into main Mar 3, 2025
11 of 12 checks passed
@zoumo zoumo deleted the improve-update-order branch March 3, 2025 12:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力
2 participants