Skip to content

feat: handle empty stack in preview #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruquanzhao merged 2 commits into from
May 2, 2025
+16 −9
Merged

feat: handle empty stack in preview #1423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4ad9df
feat: Handel empty stack in preview
7h3-3mp7y-m4n Apr 24, 2025
4ef1bc4
feat: handle empty stack in preview
7h3-3mp7y-m4n Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions pkg/cmd/preview/preview.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,12 +240,17 @@ func (o *PreviewOptions) Run() error {
return err
}

// return immediately if no resource found in stack
if spec == nil || len(spec.Resources) == 0 {
if spec == nil {
if o.Output != jsonOutput {
fmt.Println(pretty.GreenBold("\nNo resource found in this stack."))
fmt.Println(pretty.YellowBold("\nSpec is nil. Treating as empty spec."))
}
spec = &apiv1.Spec{}
}

if len(spec.Resources) == 0 {
if o.Output != jsonOutput {
fmt.Println(pretty.YellowBold("\nNo resources found in the spec."))
}
return nil
}

// compute state
Expand Down
12 changes: 7 additions & 5 deletions pkg/server/manager/stack/execute.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,13 @@ func (m *StackManager) PreviewStack(ctx context.Context, params *StackRequestPar
return nil, err
}

// return immediately if no resource found in stack
// todo: if there is no resource, should still do diff job; for now, if output is json format, there is no hint
if sp == nil || len(sp.Resources) == 0 {
logutil.LogToAll(logger, runLogger, "Info", "No resource change found in this stack...")
return nil, nil
// Treat nil spec as empty and continue with diff
if sp == nil {
logutil.LogToAll(logger, runLogger, "Warn", "Generated spec is nil, treating as empty spec...")
sp = &apiv1.Spec{}
}
if len(sp.Resources) == 0 {
logutil.LogToAll(logger, runLogger, "Info", "No resources found in spec. Proceeding with full diff.")
}

// Preview
Expand Down
Loading