Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Make swiping of plugins/sources less sensitive #1219

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

Skeltons
Copy link
Contributor

Make swiping source/plugins less sensitive, related issue #1199

video_2024-08-17_17-33-34.mp4

@rajarsheechatterjee rajarsheechatterjee merged commit d9d7d3a into LNReader:master Aug 17, 2024
1 check passed
@Palloxin
Copy link
Contributor

#1199
this would help too

@Palloxin
Copy link
Contributor

Palloxin commented Aug 17, 2024

Btw 62 is too much. It's cranky now. Can u try 35?

@Skeltons
Copy link
Contributor Author

I have tried 50 and it was still triggering the swipe, i think this would be quite hard to balance

@Palloxin
Copy link
Contributor

Palloxin commented Aug 17, 2024

In ny opinion it's enough to lower the sensivity to 30-40 (edit: 28) reducing the issue until a 30° angle thresold is implemented. I am not sure if it will be implemented before stable 2.0.0

@Skeltons
Copy link
Contributor Author

It is currently hard coded but the best way is probably to turn it into a function of your phone's width

@Palloxin
Copy link
Contributor

Palloxin commented Aug 17, 2024

I just tested with 35, seems fine to me. I hardly managed to get an unwanted trigger. Not sure on tablets.
https://github.com/Palloxin/lnreader-clone/actions/runs/10432148323
build with 35

@Skeltons
Copy link
Contributor Author

If you dont mind can i have your phone model

@rajarsheechatterjee
Copy link
Member

In my opinion, we shouldn't adjust its value based on lower-end or older devices. If it's working well for most devices, that's sufficient. He uses a Huawei P8 Lite 2017.

@Palloxin
Copy link
Contributor

Palloxin commented Aug 17, 2024

My device is very smooth when using plugin cards, it's not due to that because there is no lag, surprisingly. (yes that's my device)

@Skeltons
Copy link
Contributor Author

My device is very smooth when using plugin cards, it's not due to that because there is no lag, surprisingly.

Ah its a misunderstanding i wanted to know your device so i can get the width and find a correlation

@Palloxin
Copy link
Contributor

Palloxin commented Aug 17, 2024

1080x1920. Maybe a % value would be better? I am not sure if that value is a %, just saying.

@CheshireCat27
Copy link

CheshireCat27 commented Aug 17, 2024

Tested on a Moto One 5G Ace, was able to get minor hitching when installing plugins, but nothing else. Tested on r1014.

@CheshireCat27
Copy link

I have a painfully slow tablet I can test on as well if it would be helpful. However it barely runs a handful of Firefox tabs so I wouldn't say its indicative of the average low end device.

@Palloxin
Copy link
Contributor

Palloxin commented Aug 17, 2024

Here is my data, I used an autoclicker with precise coordinates, Macrorify.
-720x1280 (I changed it through settings)
-speed: 20

Value 35 (minimum non-responsive swipe width: 65px or 9%)

TYyBMmuU.mp4

Value 62 (minimum non-responsive swipe width: 115px or 16%)

i8SsPHen.mp4

PS: if the extension opens it means the swipe failed to trigger the plugin card

@Palloxin
Copy link
Contributor

Palloxin commented Aug 17, 2024

Practical test videos:
Value: 30↓
Comfortable, no unwanted trigger (except when it reaches the bottom)
https://github.com/Palloxin/lnreader-clone/actions/runs/10432322464

YouCut_20240817_162216607.mp4

Value 25↓
Some unwanted trigger start to appear. 30 is better.
https://github.com/Palloxin/lnreader-clone/actions/runs/10432925652

YouCut_20240817_162946545.mp4

@Palloxin
Copy link
Contributor

Palloxin commented Aug 17, 2024

The default value was 10(before this commit). Three times it reduces the problems by 90%.
Stopping completely unwanted triggers comes with the price of cranky plugin cards.
It's better to just reduce them.
I suggest 28.

@Skeltons
Copy link
Contributor Author

Ok that sounds like a good compromise, pretty unrealistic to expect no triggers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants