Update global search result if added to library #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagami
reviewed
Jan 31, 2025
| @@ -157,7 +157,7 @@ const GlobalSearchSourceResults: React.FC<{ item: GlobalSearchResult }> = ({ | |||
| </View> | |||
| </> | |||
| ), | |||
| [item.isLoading], | |||
| [item.isLoading, library], | |||
There was a problem hiding this comment.
I dont see library was used in useMemo body
There was a problem hiding this comment.
Is using library as the dependency instead of novelInLibrary better?
There was a problem hiding this comment.
well novelinlibrary changes every render
so would need to wrap novelinlibrary with a useCallback dependant on library if we did that
and it would be the same thing in the end xd
(idk maybe that would be better best practice for react tho?)
nyagami
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added usememo in better globalsearch pr