Spectral Fitting Calibrators #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some example plots from Frits' script. If you want to test the reference command is:
|
jwpetley
commented
Feb 4, 2025
jwpetley
commented
Feb 4, 2025
|
Nice work. I ran it on a random pointing and it worked for me. I have put a couple of comments above that either of us can address tomorrow. |
jwpetley
commented
Feb 5, 2025
plot_field.py
Outdated
| @@ -1171,10 +1171,12 @@ def generate_catalogues( | |||
| # Empty columns for fitting parameters | |||
There was a problem hiding this comment.
Part of the error mentioned in the slack comes from this I think. This is inside the else statement that checks if LoTSS coverage was available for the lbcs catalogue. If we move this section to outside the if-else (maybe line 1239) immediately before we grab the spectral information then I think it should work
|
Should include a reduced chi square (or state the DoF, I think all fits will have at least 3 data points). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit adds some ignores, adds Frits' script and implements it so that where it works (lots of try, except!) a plot will be made for every source in
delay_calibrators.csv.