Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt w.r.t. coq/coq#18996. #626

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

ppedrot
Copy link
Collaborator

@ppedrot ppedrot commented May 3, 2024

No description provided.

@ppedrot
Copy link
Collaborator Author

ppedrot commented May 3, 2024

@gares this seems to be failing but I do not understand why. I get

Error: Destructing let on this type expects 2 variables.

in some elpi test but I don't see how this fix and the corresponding PR on master can change the current behaviour. Are you by any chance sending weirdly ill-formed case nodes to the pretyper before going through the kernel and relying on doing this failing early somewhere specifically?

@ppedrot ppedrot force-pushed the case-info-rm-tags branch from eb836ae to 4520be1 Compare May 4, 2024 10:01
@ppedrot
Copy link
Collaborator Author

ppedrot commented May 4, 2024

Indeed, there is some trickery involved in detyping. I ended up emulating the old behaviour through an explicit registering in the upstream PR. @gares tell me if you're fine with the now explicit hack.

@SkySkimmer SkySkimmer marked this pull request as ready for review May 13, 2024 13:11
@SkySkimmer SkySkimmer merged commit bdb3474 into LPCIC:coq-master May 13, 2024
15 of 16 checks passed
@ppedrot ppedrot deleted the case-info-rm-tags branch May 13, 2024 15:11
@gares
Copy link
Contributor

gares commented Jun 20, 2024

Indeed, there is some trickery involved in detyping. I ended up emulating the old behaviour through an explicit registering in the upstream PR. @gares tell me if you're fine with the now explicit hack.

I missed this PR and I think it is a horrible hack. But I guess it is too late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants