Fast check for the presence of a universe in the environment. #633
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code was very inefficient, as it was basically rebuilding the whole set of universes from the environment in O(n) at each invocation.
|
Thanks! May I ask how you found this inefficiency? Is there a development suffering from this problem in CI? |
|
Random runtime profiling of mathcomp while I was debugging something else. FTR there are a lot of low-hanging fruits in coq-elpi, the leading one being probably the little dance to keep global and local constraints in sync, which accounts for 1/3 of the coq-elpi runtime or so on average. |
|
Yup. You did tell me in some API it should be possible to just thread this data instead of recomputing it, but I naver managed to find the time to try to kill the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was very inefficient, as it was basically rebuilding the whole set of universes from the environment in O(n) at each invocation.