-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to https://github.com/coq/coq/pull/19530 #688
Conversation
f507213
to
47daab2
Compare
fe2bb89
to
d60f59f
Compare
Co-authored-by: Enrico Tassi <[email protected]>
@if $$(coqc --version | grep -q "8.19\|8.20") ; then \ | ||
sed -e 's/@@STDLIB_THEORY@@//' $< >> $@ ; \ | ||
else \ | ||
sed -e 's/@@STDLIB_THEORY@@/(theories Stdlib)/' $< >> $@ ; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@proux can't we provide a stdlib-shim package for coq < 9 ?
Unless elpi is the only package needing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, coq-elpi is the only thing in the whole Coq CI that need this, so not sure it would be worth it. In any case, we should get rid of that dependency here (or at least isolate it to apps that really need it and put them in a separate coq-elpi-extra-apps or so package).
Upstream PR merged, please merge |
@gares sorry to be a bit pushy, but a lot of stuff in the Coq CI depends on elpi, could you try to merge this asap so that we stabilize the Coq CI quickly? -- Your desperate Rocq RM, truly. |
ACK, but this is a somewhat non-trivial PR and I didn't want to interfere too much. |
Adapt to coq/coq#19530
To be merged in sync with the upstream PR.