Declare compatibility constant as canonical gref for primitive projections #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is Either you can close this PR and use the existing API (if it works for you) or we find a way to merge the two. |
|
I missed |
gares
reviewed
Mar 4, 2025
elpi/coq-lib.elpi
Outdated
| @@ -510,6 +510,7 @@ coq.term->gref (global GR) GR :- !. | |||
| coq.term->gref (pglobal GR _) GR :- !. | |||
| coq.term->gref (app [Hd|_]) GR :- !, coq.term->gref Hd GR. | |||
| coq.term->gref (let _ _ T x\x) GR :- !, coq.term->gref T GR. | |||
| coq.term->gref (primitive (proj Proj _)) GR :- !, primitive-projection? Proj GR. | |||
There was a problem hiding this comment.
Suggested change
| coq.term->gref (primitive (proj Proj _)) GR :- !, primitive-projection? Proj GR. | |
| coq.term->gref (primitive (proj Proj _)) (con C) :- coq.env.primitive-projection? Proj C, !. |
There was a problem hiding this comment.
I am surprised I did not see any error. Is it not const instead of con?
gares
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, we can not obtain a gref out of a primitive projection, although the compatibility constant is a canonical gref associated to it. This is useful when we want to turn a term into a cs-pattern (although I guess I could also add a clause to the latter predicate).