Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsonc parser issue with quotes in strings #15

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Conversation

sveinse
Copy link
Member

@sveinse sveinse commented Apr 13, 2024

This PR fixes issues with JSON files that contains statements with a single escaped quote, like "value": "Hello\" World". This was due to the JSONC parser that were confused by the quote.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.67%. Comparing base (98e7c24) to head (77c02b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   45.67%   45.67%           
=======================================
  Files          21       21           
  Lines        6612     6612           
=======================================
  Hits         3020     3020           
  Misses       3592     3592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sveinse sveinse merged commit e7aeb5f into main Apr 13, 2024
6 checks passed
@sveinse sveinse deleted the fix-jsonc-bug branch April 13, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant