This repository was archived by the owner on Jan 5, 2019. It is now read-only.
[WIP] Integrating the Rotation Feature for the OpenSeadragon Viewer and the Plyr media player#128
Closed
jrgriffiniii wants to merge 15 commits intoLafayetteCollegeLibraries:masterfrom
jrgriffiniii:issues-105-griffinj
Closed
[WIP] Integrating the Rotation Feature for the OpenSeadragon Viewer and the Plyr media player#128jrgriffiniii wants to merge 15 commits intoLafayetteCollegeLibraries:masterfrom jrgriffiniii:issues-105-griffinj
jrgriffiniii wants to merge 15 commits intoLafayetteCollegeLibraries:masterfrom
jrgriffiniii:issues-105-griffinj
Conversation
RangeLimit only works with integers. This component allows ranges to be created from timestamps + `<input type="month|date"/>` elements. It still needs a wrapper component (similar to `<RangeLimitFacetWrapper />`) that will parse ISO date values (which, I believe, is how we'll be receiving/sending values from the repository) into said timestamps. This does a lot of computing + would be a good candidate for a refactor. Perhaps using WebWorkers?
adds functions for range facets: - calculateRange - date-intervals (constants related to dates) - formatDateValue and adds tests for `calculateRange`
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases #64, resolves #43, and also resolves #105