This repository was archived by the owner on Jan 5, 2019. It is now read-only.
[WIP] Implementing the MediaPlayer, Audio, and Video Components#149
Open
jrgriffiniii wants to merge 2 commits intoLafayetteCollegeLibraries:masterfrom
Open
[WIP] Implementing the MediaPlayer, Audio, and Video Components#149jrgriffiniii wants to merge 2 commits intoLafayetteCollegeLibraries:masterfrom
jrgriffiniii wants to merge 2 commits intoLafayetteCollegeLibraries:masterfrom
Conversation
Contributor
Author
|
The current state of this PR is 👎 (there is definitely refactoring and abstraction needed) , but I would greatly appreciate any feedback and advice before I proceed further. |
|
Changes Unknown when pulling 05b23db on jrgriffiniii:issues-105-plyr-griffinj into ** on LafayetteCollegeLibraries:master**. |
Contributor
Author
|
Commit 05b23db integrates the |
rococodogs
reviewed
Apr 4, 2017
Member
rococodogs
left a comment
There was a problem hiding this comment.
👍 looks very good to me! can confirm that the video plays when the viewer is opened
Member
|
If I have any suggestions for refactoring so far, it would be to maybe make the function Audio (props) {
const { sources, ...audioProps } = props
return (
<audio {...audioProps}>
{ (sources || []).map((s, idx) => <source {...s} key={idx} />) }
</audio>
)
}
function Video (props) {
const { sources, captions, ...videoProps } = props
return (
<video {...videoProps}>
{ (sources || []).map((s, idx) => <source {...s} key={idx} />) }
{ captions ? <track {...captions} key="captions" /> : '' }
</video>
)
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #105