2024.8 #1137
Merged
2024.8 #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use assignFAST as authority for #subject * leave leading zeros where present * fix feature spec
* local fits_servlet container for configurability * add logging configuration for fits
* run feature specs using firefox * update circleci config * remove extraneous flags
* first pass @ lint * check compose version * whoops * put off docker compose until we can use our new .envs * install test gems * whoops * use bundler-cache to kick off install * pull circleci config * restore circleci job to be noop * fix circleci * once more * 🙃 * start breaking out test job * first pass @ running tests * solr first pass * fix solr config path * run test in ubuntu container to access network * install system dependencies first * sudo not found? * split build into its own step * fix needs * update apt * 🙃 * ok let's try using the dockerfile setup * split rubo into its own :lint group * try that manually * cache lint gems * it's always that one character * ok maybe we need to be explicit * try setting up the services before the app * install chrome dependencies * enable cloud mode for solr * *sigh* let's try this again * we're really not including curl with coreutils ok * try solr using bitnami example config * add solr auth * *sigh* guess we need node after all * skip lint while troubleshooting testsa * postgres :( * whoops * try starting zookeeper before solr * make sure chrome install path is in PATH * try using WD_CHROME_PATH for webdrivers * try stable channel of chrome * restore lint check * add code coverage report * some niceties * add titles * clear out old (unused) tools * use ruby/setup-ruby action for gems * remove dev seeds for now * revert :lint group changes * revert gem install on test to our own caching we need to update ruby before we can use the setup/ruby gem inside the test * put bundle config at the top of test * update Gemfile.lock * add firefox to gha * use firefox / silence deprecations / rubo github output * only require rspec-github if in CI * newline * omfg rubo * try using firefox latest-esr * add gtk3 package for firefox * libgtk-3-0 * install recommends why not? * fingers crossed * ..... * fix rspec-github * silence all warnings in CI runs via env * add geckodriver * add geckodriver to PATH * i guess setup-geckodriver doesn't have exports * maybe rspec-github isn't worth it * sigh * let's try * i can't say the deprecation hiding was doing anything * build 'develop' images on PR merge * run lint_and_test before the release process * don't run lint_and_test twice for prereleases * try triggering reusable workflow on push as separate workflow * use branches-ignore * ? * how about... ? * permissions * delete caches after closing branch * names
* set up undercover-ci * ugh * i am going to fight rubocop * fix undercover command
* use FAST api for subject labels * whoops * fix tests * acab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates ✨
subjectnow uses assignFAST as its authority, rather than OCLC's deprecated (?) RDF service (use assignFAST as authority for #subject #1133, bugfix: use FAST API service to fetch labels #1139)developautomatically trigger "prerelease" container buildsdevelop