Cogwheel Skull #610
Cogwheel Skull #610
Conversation
|
Please add the name of the item into language file, referring to the doc |
|
Marking this as a draft so I don't accidentally merge it, please mark it as ready for review once the lang keys have been added |
Removed redundant line in the ammo definition Added a tooltip along with the name to lang file Additionally unified all names for "Blast-Resistant" and "Fire-Resistant" blocks into one format
The-Shortman
added
type: enhancement
| }, | ||
| ]; | ||
| createastralTooltips.forEach((tooltip) => addLocalizedShiftTooltip(event, tooltip.item, tooltip.tooltip)); | ||
| event.add("createastral:cogwheel_skull", Text.of(Component.translate("tooltip.createastral.cogwheel_skull")).gray()); |
There was a problem hiding this comment.
Oh, I just saw this code. I think I saw some issues. Maybe we need to do some testing?
Including the following, I think adding Component.translate to Text.of is strange.
I think the normal approach should be Component.translate("tooltip.createastral.cogwheel_skull").gray()
There was a problem hiding this comment.
Gosh, this was what I did a year ago. What an idiot!
There was a problem hiding this comment.
Yeah I don't actually know how any of that works, just copied from the code below. Can remove it if you think it shouldn't be there, but I don't think it affects the end result
The-Shortman
removed
the
status: awaiting approval
|
I think I can safely merge this pull request |
3 participants
Adds the coghweel skull as a placeable block and potato cannon projectile (Applies a "time stop" AOE on impact)
Also fixes some block name inconsistencies