Skip to content

Merge feature/ponders into Astral-Experimental #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: Astral-Experimental
Choose a base branch
from
Draft

Merge feature/ponders into Astral-Experimental #617

wants to merge 7 commits into from

Conversation

@The-Shortman
Copy link
Collaborator

@The-Shortman The-Shortman commented Aug 25, 2025 •
edited
Loading

This pull request:

  • Standardises the ponder tag registry into a const/forEach loop.
  • Adds a ponder entry for all custom machinery currently missing a ponder.
  • Reworks existing ponder entries to match the style of the rest of the ponder index in terms of grammar and legibility.
  • Improves the animations of the existing ponders to give them a bit more of a visual flair.
  • Adds lang keys to the ponders for i18n purposes.

@The-Shortman The-Shortman added this to the Version 2.2 milestone Aug 25, 2025
@The-Shortman The-Shortman self-assigned this Aug 25, 2025
@The-Shortman The-Shortman added type: documentation This pull request improves any form of documentation. type: enhancement This pull request adds/this issue requests a new feature. type: bugfix This pull request closes a bug report issue or a collection of bug report issues. labels Aug 25, 2025
@The-Shortman The-Shortman linked an issue Aug 25, 2025 that may be closed by this pull request
[Bug]: Signal Coordinator ponder is broken #437
Open
4 tasks
nageih
nageih reviewed Aug 25, 2025
View reviewed changes
kubejs/client_scripts/ponder_misc.js Outdated
namespace: "kubejs:createastral_tips", // Anything unique to astral that isn't a machine or part of a kubejs addon e.g. astralsignals
icon: "createastral:astral_singularity",
displayName: "Create: Astral Tips",
tooltip: "Tips and tricks specific to this modpack",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder, I'm not sure how it works. If necessary, the texts may need to be translated. Thank you for your help.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it will be automatically generated in kubejs/assets/ponderjs_generated/lang? I'm not sure.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add this to the to-do list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nageih nageih nageih left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@The-Shortman The-Shortman

Labels

type: bugfix This pull request closes a bug report issue or a collection of bug report issues. type: documentation This pull request improves any form of documentation. type: enhancement This pull request adds/this issue requests a new feature.

Projects

None yet

Milestone

Version 2.2

Development

Successfully merging this pull request may close these issues.

[Bug]: Signal Coordinator ponder is broken

3 participants

@The-Shortman @nageih