Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change Kurtosis API version to v1.4.4 #205

Merged
merged 7 commits into from
Feb 18, 2025

Conversation

MegaRedHand
Copy link
Collaborator

@MegaRedHand MegaRedHand commented Feb 4, 2025

This PR updates the Kurtosis API version to v1.4.4. The Kurtosis team decided to move back to v1 because of problems with the Go toolchain.

This PR also skips the hello-world-avs job in the CI. Foundry recently changed the optimizer to be disabled by default and we need to enable it to have reasonably sized contracts. I opened this PR in the other repo: Layr-Labs/hello-world-avs#108 and pinned it in the example. Just updating the reference to the HW repo won't work (see #185)

@samlaf
Copy link

samlaf commented Feb 4, 2025

Thanks for this. Not sure what's the best solution here when trying to use different kurtosis packages that require different versions of the sdk (which in turn only work with a single version of the kurtosis engine, which I believe (?) only one can be running at a time).

op is on v1.4.3 hence me asking to downgrade here.

@MegaRedHand MegaRedHand marked this pull request as ready for review February 17, 2025 22:31
@MegaRedHand MegaRedHand force-pushed the downgrade-kurtosis-api-version branch from 957922b to 29a71ee Compare February 18, 2025 13:22
@MegaRedHand
Copy link
Collaborator Author

I bumped the API version to v1.4.4 since op seems to have bumped it too. Seems like the kurtosis-cli package version 2 was already unlisted from brew, so I'll try to make a new release today with this PR's changes.

@MegaRedHand MegaRedHand self-assigned this Feb 18, 2025
pablodeymo
pablodeymo previously approved these changes Feb 18, 2025
@MegaRedHand MegaRedHand enabled auto-merge (squash) February 18, 2025 13:32
@MegaRedHand MegaRedHand changed the title chore!: downgrade Kurtosis API version to v1.4.3 fix: change Kurtosis API version to v1.4.4 Feb 18, 2025
@MegaRedHand MegaRedHand force-pushed the downgrade-kurtosis-api-version branch from 19c4c82 to 4fb477c Compare February 18, 2025 19:01
@MegaRedHand MegaRedHand merged commit 89ae02c into main Feb 18, 2025
12 checks passed
@MegaRedHand MegaRedHand deleted the downgrade-kurtosis-api-version branch February 18, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants