Bump EigenSDK to v0.2.0-beta.1 for compatibility with new Holesky Deploy #45
Conversation
afkbyte
changed the title
afkbyte
changed the title
There was a problem hiding this comment.
Mostly LGTM, but I'm out of the loop on eigenlayer and sdk stuff, so tagging @shrimalmadhur for another review.
Also @ian-shim to make sure this change is fine for eigenda.
avssync/avssync.go
Outdated
| AvsReader avsregistry.ChainReader | ||
| AvsWriter avsregistry.ChainWriter |
There was a problem hiding this comment.
what's this change exactly? Haven't touched the sdk in a while so not sure. Is this the change that fixes the "no slasher founder" issue?
There was a problem hiding this comment.
yeah so changing to the new avs chainreader and chainwriter fixes the issue because they're no longer checking for the slasher which no longer exists on holesky
Can see the diff: https://github.com/Layr-Labs/eigensdk-go/pull/342/files
There was a problem hiding this comment.
Oh this is interface renaming
We had bad naming - avsRegistry.AvsRegistryChainReader. We replaced it with avsRegistry.ChainReader
There was a problem hiding this comment.
And what afk said - this version of sdk removes slasher contract binding generation so fixes the issue.
Motivation
AVS were seeing the following error when running the current version of avs sync post-holesky upgrade:
Failed to create ELChainReader: Failed to fetch Slasher address: execution reverted)"Solution
Bumps EigenSDK to v0.2.0-beta.1
Open questions
We don't include the AllocationManager in the legacyNewEigenlayerContractBindingssee: https://github.com/Layr-Labs/eigensdk-go/blob/a0cf13a02ec6777ec40c237e8b2c48ee6b3ce78e/chainio/clients/elcontracts/bindings.go#L133 which is used to create the bindings for the avsRegistry reader and writer. This means that this new branch should work on both holesky and mainnet - but was this intentional?Edit: Realized it probably is because the AllocationManager can be derived from the DelegationManager