Improve error message clarity in IDelegationManager interface#1295
Closed
GarmashAlex wants to merge 7 commits intoLayr-Labs:mainfrom
GarmashAlex:hpp31
Closed
Improve error message clarity in IDelegationManager interface#1295GarmashAlex wants to merge 7 commits intoLayr-Labs:mainfrom GarmashAlex:hpp31
GarmashAlex wants to merge 7 commits intoLayr-Labs:mainfrom
GarmashAlex:hpp31
Conversation
**Motivation:** chain_id is currently an github secrets, but not used anywhere **Modifications:** remove chain id from secrets and env vars **Result:** one less useless secret, no impact on ci
**Motivation:** per eigengit, main will be the new canonical branch **Modifications:** change push branch from dev to main **Result:** ci will be run on PRs against main
**Motivation:** fork-based pr cannot use secrets or github token **Modifications:** disable auto labeler to prepare for enabling fork-based pr **Result:** auto labeler is disabled, will be potentially removed in future soon
**Motivation:** *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* **Modifications:** *Describe the modifications you've done.* **Result:** *After your change, what will change.*
**Motivation:** remove holesky rpc since it's not used anywhere **Modifications:** remove holesky rpc **Result:** remove holesky rpc
**Motivation:** make testing of fork based pr easier by splitting workflows require secrets vs not **Modifications:** splitting workflows require secrets vs not into 2 gh workflow files **Result:** splitting workflows require secrets vs not into 2 gh workflow files
Enhanced error message readability in the IDelegationManager interface by adding more descriptive documentation to error declarations. Added a new InputAddressZero error to handle zero address input validation more explicitly. These improvements make error messages more informative for developers working with the delegation system, providing better context when issues occur during contract interactions.
bowenli86
force-pushed
the
main
branch
4 times, most recently
from
b6b9c4c to
5ffb1b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The current error messages in IDelegationManager don't provide enough context when exceptions occur. When errors are thrown during contract interactions, developers need to search through the codebase to understand what caused the issue. This lack of clarity increases debugging time and makes the system harder to use, especially for new developers integrating with EigenLayer.
Modifications:
Result:
After these changes, developers will receive more informative error messages when interacting with the delegation system. This will streamline the debugging process, reduce integration time, and make the codebase more maintainable. The improved error documentation also serves as better self-documentation for the contract's expected behavior, without changing any of the actual contract logic or execution flow.