chore(logger): log full set of RewardsCoordinator deployment parameters #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

tomasandroil wants to merge 1 commit into Layr-Labs:main from tomasandroil:fix/update

tomasandroil commented Apr 24, 2025

Improved observability of the deployment configuration by completing the previously unfinished TODO in logInitialDeploymentParams().

Modifications:

Completed the // todo log all rewards coordinator params section
Added logs for:
- REWARDS_COORDINATOR_CALCULATION_INTERVAL_SECONDS
- REWARDS_COORDINATOR_MAX_REWARDS_DURATION
- REWARDS_COORDINATOR_MAX_RETROACTIVE_LENGTH
- REWARDS_COORDINATOR_MAX_FUTURE_LENGTH
- REWARDS_COORDINATOR_GENESIS_REWARDS_TIMESTAMP
- REWARDS_COORDINATOR_UPDATER
- REWARDS_COORDINATOR_ACTIVATION_DELAY
- REWARDS_COORDINATOR_DEFAULT_OPERATOR_SPLIT_BIPS
- REWARDS_COORDINATOR_OPERATOR_SET_GENESIS_REWARDS_TIMESTAMP
- REWARDS_COORDINATOR_OPERATOR_SET_MAX_RETROACTIVE_LENGTH

Result:

All critical RewardsCoordinator params are now properly logged during deployments
This improves transparency and aids validation across environments


          Update ExistingDeploymentParser.sol

8b5a027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet