Skip to content

release: Reduce allocation configuration delay & min withdrawal delay on Holesky #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

solimander
Copy link
Contributor

@solimander solimander commented Apr 24, 2025

Motivation:

  • The current delays on Holesky testnet are too lengthy for efficient testing:
    • ALLOCATION_CONFIGURATION_DELAY: 75 blocks (~15 minutes)
    • DEALLOCATION_DELAY: 50 blocks (~10 minutes)
    • MIN_WITHDRAWAL_DELAY_BLOCKS: 50 blocks (~10 minutes)
  • This release reduces these delays to enable faster iteration and testing:
    • ALLOCATION_CONFIGURATION_DELAY: reduced to 30 blocks (~6 minutes)
    • DEALLOCATION_DELAY: 25 blocks (~5 minutes)
    • MIN_WITHDRAWAL_DELAY_BLOCKS: reduced to 25 blocks (~5 minutes)

Modifications:

  • Added a new release folder script/releases/v1.4.2-testnet-delay-reduction/:
    • 1-deployContracts.s.sol – Deploys fresh AllocationManager and DelegationManager implementations, with the lowered ALLOCATION_CONFIGURATION_DELAY and MIN_WITHDRAWAL_DELAY pulled from Env.
    • 2-queueUpgrade.s.sol – Queues the upgrade transaction via the multisig and TimelockController.
    • 3-executeUpgrade.s.sol – Executes the queued upgrade transaction via the multisig and TimelockController after the timelock delay.
    • upgrade.json – Defines the three-phase release (eoa, multisig queue, multisig execute) for Zeus, coordinating the execution of the scripts above.

Result:

  • The AllocationManager & DelegationManager proxy contracts on Holesky will be upgraded to point to the newly deployed v1.4.2 implementation.
  • This new AllocationManager implementation incorporates the reduced ALLOCATION_CONFIGURATION_DELAY and MIN_WITHDRAWAL_DELAY (values determined by the Holesky environment variable).
  • This new DelegationManager implementation incorporates the reduced MIN_WITHDRAWAL_DELAY (value determined by the Holesky environment variable).

Notes:

This is a testnet-only upgrade.

@solimander solimander added the 🚢 Deployment Code deployed to testnet or mainnet. label Apr 24, 2025
@solimander solimander changed the base branch from main to v1.4.2 April 24, 2025 21:16
@solimander solimander requested a review from 8sunyuan April 24, 2025 21:35
Copy link
Contributor

@8sunyuan 8sunyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will wait for someone on protocol to approve as well

@solimander solimander changed the title feat(release): Reduce AllocationManager configuration delay on Holesky release: Reduce allocation configuration delay & min withdrawal delay on Holesky Apr 28, 2025
Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ypatil12
Copy link
Collaborator

Also I think the README has a typo?

Configuration Delay should be 6 mins. Withdrawal delay should be 5 minutes

@ypatil12 ypatil12 merged commit 336cab3 into Layr-Labs:v1.4.2 Apr 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚢 Deployment Code deployed to testnet or mainnet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants