-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal restructure to demo Concept/How To/Reference/Tutorial approach #420
Conversation
@MadelineAu is attempting to deploy a commit to the EigenLabs Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@MadelineAu Overall I'm a fan of the new organization - it feels very reasonably and logically organized. I don't see any red flags and in general I want to defer to you preference where possible. It might be good to double check with Nader in case he'd like to weigh in as a next step? Some of the current design decisions were with his guidance in the interests of new developers. Tactical feedback:
|
A couple of thoughts:
|
Thanks for the feedback @wesfloyd and @dabit3. Addressed as follows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@wesfloyd - put together this draft PR to show how a Concept/HowTo/Reference/Tutorial restructure would look. It's very minimal so far - only moves and renames topics. I wanted to get your thoughts before going any further and putting redirects in place.
The diffs won't be great for seeing what I'm trying to do - you'll probably need to pull the branch and build locally.