Skip to content

Commit

Permalink
Fix metadata uri signature (#205)
Browse files Browse the repository at this point in the history
* updating for compliance with interface

* fix: updatng comment to reflect function rename
  • Loading branch information
RonTuretzky authored Mar 11, 2024
1 parent 9236bb7 commit 036e9d4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/ServiceManagerBase.sol
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ abstract contract ServiceManagerBase is IServiceManager, OwnableUpgradeable {
}

/**
* @notice Sets the metadata URI for the AVS
* @notice Updates the metadata URI for the AVS
* @param _metadataURI is the metadata URI for the AVS
* @dev only callable by the owner
*/
function setMetadataURI(string memory _metadataURI) public virtual onlyOwner {
function updateAVSMetadataURI(string memory _metadataURI) public virtual onlyOwner {
_avsDirectory.updateAVSMetadataURI(_metadataURI);
}

Expand Down
4 changes: 2 additions & 2 deletions src/interfaces/IServiceManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import {IDelegationManager} from "eigenlayer-contracts/src/contracts/interfaces/
*/
interface IServiceManager {
/**
* @notice Sets the metadata URI for the AVS
* @notice Updates the metadata URI for the AVS
* @param _metadataURI is the metadata URI for the AVS
*/
function setMetadataURI(string memory _metadataURI) external;
function updateAVSMetadataURI(string memory _metadataURI) external;

/**
* @notice Forwards a call to EigenLayer's DelegationManager contract to confirm operator registration with the AVS
Expand Down
4 changes: 2 additions & 2 deletions test/integration/CoreRegistration.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ contract Test_CoreRegistration is MockAVSDeployer {
require(operator != serviceManager.owner(), "bad test setup");
cheats.prank(operator);
cheats.expectRevert("Ownable: caller is not the owner");
serviceManager.setMetadataURI("Test MetadataURI");
serviceManager.updateAVSMetadataURI("Test MetadataURI");
}

event AVSMetadataURIUpdated(address indexed avs, string metadataURI);
Expand All @@ -180,7 +180,7 @@ contract Test_CoreRegistration is MockAVSDeployer {
cheats.prank(toPrankFrom);
cheats.expectEmit(true, true, true, true);
emit AVSMetadataURIUpdated(address(serviceManager), "Test MetadataURI");
serviceManager.setMetadataURI("Test MetadataURI");
serviceManager.updateAVSMetadataURI("Test MetadataURI");
}

// Utils
Expand Down

0 comments on commit 036e9d4

Please sign in to comment.