feat: ecdsa basic registry #194
Conversation
Co-authored-by: steven <[email protected]>
Co-authored-by: steven <[email protected]>
* refactor: minWithdrawalDelayBLocks from core * fix: core contracts commit and tests * feat: add avs directory to service manager * fix: rebase off updated bls sig checker; update integration tests * Add AVS Directory Support to Service Manager (#156) * update: change core submodule branch * feat: add avs directory to service manager * fix: rebase off updated bls sig checker; update integration tests * fix: core contracts commit and tests * feat: add avs directory to service manager * fix: rebase off updated bls sig checker; update integration tests * fix: conflicts --------- Co-authored-by: 8sunyuan <[email protected]> * fix: submodule commit * fix: rebase changes * Add AVS Directory Support to Service Manager (#156) * update: change core submodule branch * feat: add avs directory to service manager * fix: rebase off updated bls sig checker; update integration tests * fix: core contracts commit and tests * feat: add avs directory to service manager * fix: rebase off updated bls sig checker; update integration tests * fix: conflicts --------- Co-authored-by: 8sunyuan <[email protected]> * fix: submodule commit * fix: rebase changes * Add AVS Directory Support to Service Manager (#156) * update: change core submodule branch * feat: add avs directory to service manager * fix: rebase off updated bls sig checker; update integration tests * fix: core contracts commit and tests * feat: add avs directory to service manager * fix: rebase off updated bls sig checker; update integration tests * fix: conflicts --------- Co-authored-by: 8sunyuan <[email protected]> * fix: submodule commit * docs: AVSRegistry -> AVSDirectory --------- Co-authored-by: Yash Patil <[email protected]>
* test: fix flaky tests by removing bogosort * test: fix flaky test by rejecting empty addr inputs
* chore: add storage gaps to BLSSignatureChecker and ServiceManagerBase * chore: ServiceManagerBase to abstract and create mock * chore: use onlyInitializing in Base and initializer in mock * chore: add storage gaps to BLSSignatureChecker and ServiceManagerBase * chore: ServiceManagerBase to abstract and create mock * chore: use onlyInitializing in Base and initializer in mock * fix: core submodules --------- Co-authored-by: steven <[email protected]>
* test: gas scenarios for updateOperators * refactor: using one call for operatorShares * test: updateOperators 200 operators * test: gas scenarios for updateOperators * refactor: using one call for operatorShares * test: updateOperators 200 operators * fix: comments
MIT instead of BSL-MIT mix
slightly less memory ops in `orderedBytesArrayToBitmap` fnc
* fix: include missing fields in TYPEHASH defintion the `salt` and `expiry` fields were missing from the `OPERATOR_CHURN_APPROVAL_TYPEHASH` def * fix: correct definition of OperatorKickParam inside of typehash def
…180) * chore: clean up loops to iterate downward and remove unneeded checks * docs: clarifying comments around quorum existence checks
|
@stevennevins seems like @ChaoticWalrus is good with this / the remaining comments are minor - any blockers to get this over the line? |
@ChaoticWalrus, I just wanted to confirm we're aligned on the changes for the remaining unresolved items. Also if you see any hurdles to getting this in |
Things are looking fine to me, overall. |
src/unaudited/ECDSAStakeRegistry.sol
Outdated
| revert InvalidSignedWeight(); | ||
| } | ||
| uint256 thresholdStake = _getThresholdStake(_referenceBlock); | ||
| if ((thresholdStake * BPS)/ totalWeight > (_signedWeight * BPS) / totalWeight){ |
There was a problem hiding this comment.
looks like you actually totally changed the meaning of thresholdStake to be the literal amount required to sign?
this check could now just be if( thresholdStake > _signedWeight ) because you're doing the exact same manipulations on both sides of the inequality
There was a problem hiding this comment.
Addressed in 79d95aa
There was a problem hiding this comment.
I'm OK merging this into the 'unaudited' folder at this point, personally.
would be good to note any outstanding discussions, probably with some comments?
also might be nice to run this file structure by someone else, but I think it's quite clear having an "unaudited" folder 🤷
This PR introduces a simpler registry implementation as an alternative to the existing StakeRegistry.sol. This is based on the teams asking for more examples and a general requirement to use ECDSA as their signature scheme.
Also, standardizing to use an
isValidSignaturefunction is proposed to query if a set of signatures from operators are valid at a given block height which isn't contained in the other implementation but seems like a useful standardization