refactor: VetoableSlasher #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The '_slasher' parameter was not utilized within the contract, enhancing clarity by simplifying the constructor.
neutiyoo
changed the title
ypatil12
approved these changes
Jan 31, 2025
0xClandestine
pushed a commit
that referenced
this pull request
Feb 5, 2025
stevennevins
added a commit
that referenced
this pull request
Feb 5, 2025
* fix: remappings * fix: remove unused OnlySlasher error (#376) * refactor: VetoableSlasher (#377) * chore: use inheritdoc for SlashingRegCoord (#378) * test: slasher contracts and add some natspec * chore: unneeded comment * chore: redundant comments * test: more extensive setup for slashOperator * test: integrate core deployment lib * test: unit test slashing * test: vetoable slasher * chore: forge fmt * chore: format and solve interfaces with inheritdoc --------- Co-authored-by: clandestine.eth <[email protected]> Co-authored-by: Noel <[email protected]> Co-authored-by: Yash Patil <[email protected]>
0xClandestine
pushed a commit
that referenced
this pull request
Feb 6, 2025
0xClandestine
added a commit
that referenced
this pull request
Feb 6, 2025
* fix: remappings * fix: remove unused OnlySlasher error (#376) * refactor: VetoableSlasher (#377) * chore: use inheritdoc for SlashingRegCoord (#378) * test: slasher contracts and add some natspec * chore: unneeded comment * chore: redundant comments * test: more extensive setup for slashOperator * test: integrate core deployment lib * test: unit test slashing * test: vetoable slasher * chore: forge fmt * chore: format and solve interfaces with inheritdoc --------- Co-authored-by: clandestine.eth <[email protected]> Co-authored-by: Noel <[email protected]> Co-authored-by: Yash Patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
VetoableSlashercontract in thesrc/slashers/VetoableSlasher.solfile. The most important changes involve modifying function parameters and the constructor.Changes to function parameters and constructor:
_slasherparameter from the constructor ofVetoableSlasher(src/slashers/VetoableSlasher.sol).paramsparameter frommemorytocalldatain thequeueSlashingRequestfunction (src/slashers/VetoableSlasher.sol).paramsparameter frommemorytocalldatain the_queueSlashingRequestfunction (src/slashers/VetoableSlasher.sol).