test: integration with slashingRegistryCoordinator #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpsanant
reviewed
Feb 8, 2025
gpsanant
reviewed
Feb 8, 2025
gpsanant
reviewed
Feb 9, 2025
src/RegistryCoordinator.sol
Outdated
| stakeRegistry.updateOperatorsStake(operators, operatorIds, quorumNumber); | ||
| for (uint256 j = 0; j < operators.length; ++j) { | ||
| // whether the operator is registered in the core EigenLayer contract AllocationManager | ||
| bool registeredInCore = allocationManager.isMemberOfOperatorSet( |
There was a problem hiding this comment.
only do this call if it's an m2 quorum imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge case fixed:
The AllocationManager has a try/catch in the
deregisterFromOperatorSetsimplementation. This was put in place to allow operators to force deregister from an AVS. However this can lead to a weird state where an operator is registered in AVS contracts but deregistered from EigenLayer. Checks for this are added for forceDeregistration by the AVS to avoid reverts. In addition, AVSSync (updateOperatorsForQuorum,updateOperator) will now also include these operators to be force deregistered.Refactored integration tests to only use the
SlashingRegistryCoordinatorand defines aOperatorSetUsercontract.The
SlashingRegistryCoordinatorand the Registry contracts do not depend on the ServiceManager base contract.Interactions with the core protocol are integrated with UAM and setting the
avsAccountIdentifieras the unique account identifier address for the AVS. For existing AVSs, this will be the address of your ServiceManager contract.Note that integration tests with the
RegistryCoordinatorand legacy quorums will require some fork integration testing refactor and testing the legacy interfaces. This is still a TODO that should be added.