Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Various references and uses of the
SocketRegistry
contract are either incomplete or inconsistent with existing practices.Changes
SlashingRegistryCoordinator
, fixes a bug where theSocketRegistry
was not being added to the total list ofregistries
SocketRegistry
inheritance pattern to align with existing inheritance patterns (base contract -> abstract storage contract -> interface)ISlashingRegistryCoordinator
for exposing theSocketRegistry
immutable, to be consistent with all other registriesonlyCoordinationOwner
from theSocketRegistry
and related contracts / testsSocketRegistry
into the codebaseSocketRegistryStorage
from48
to49
, as there is only one state variableImpact