Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SocketRegistry-related fixes #389

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

nadir-akhtar
Copy link
Contributor

@nadir-akhtar nadir-akhtar commented Feb 7, 2025

Motivation:

Various references and uses of the SocketRegistry contract are either incomplete or inconsistent with existing practices.

Changes

  • In the SlashingRegistryCoordinator, fixes a bug where the SocketRegistry was not being added to the total list of registries
  • Improves the SocketRegistry inheritance pattern to align with existing inheritance patterns (base contract -> abstract storage contract -> interface)
  • Adds a missing external function to the interface ISlashingRegistryCoordinator for exposing the SocketRegistry immutable, to be consistent with all other registries
  • Removes the unused modifier onlyCoordinationOwner from the SocketRegistry and related contracts / tests
  • Updates documentation across contracts to accurately reflect the inclusion of the SocketRegistry into the codebase
  • Updates licenses from MIT -> BUSL-1.1, as is consistent with the codebase
  • Fixes a misset gap in SocketRegistryStorage from 48 to 49, as there is only one state variable

Impact

  • Code correctness improvement
  • Accuracy of docs
  • Consistency with other sections of the codebase

@nadir-akhtar nadir-akhtar merged commit 4f75b3c into test/slashing-release Feb 7, 2025
5 of 6 checks passed
@nadir-akhtar nadir-akhtar deleted the nadir/socket-registry-fixes branch February 7, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants