Optimize BLSSignatureChecker #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calculate operators negative APK on de/registration to prevent scalar multiplication at sigcheck runtime
gpsanant
reviewed
Nov 29, 2023
| @@ -404,6 +407,16 @@ contract BLSRegistryCoordinatorWithIndices is EIP712, Initializable, IBLSRegistr | |||
| newBitmap: newBitmap | |||
| }); | |||
|
|
|||
| //Update the operator contribution to aggregate public key across all quorums | |||
| BN254.G1Point memory operatorPubkey = blsPubkeyRegistry.getOperatorPubkey(operator); | |||
There was a problem hiding this comment.
internal function for this?
gpsanant
reviewed
Nov 29, 2023
| @@ -404,6 +407,16 @@ contract BLSRegistryCoordinatorWithIndices is EIP712, Initializable, IBLSRegistr | |||
| newBitmap: newBitmap | |||
| }); | |||
|
|
|||
| //Update the operator contribution to aggregate public key across all quorums | |||
| BN254.G1Point memory operatorPubkey = blsPubkeyRegistry.getOperatorPubkey(operator); | |||
| operatorNegativeAPKs[operatorId] = operatorNegativeAPKs[operatorId].plus( | |||
There was a problem hiding this comment.
we should get rid of the other "time series" pubkey and replace it with this
gpsanant
reviewed
Nov 29, 2023
src/BLSSignatureChecker.sol
Outdated
| ); | ||
|
|
||
| { | ||
| BN254.G1Point memory operatorNegativeAPK = registryCoordinator.getOperatorNegativeAPK(nonSignerPubkeyHashes[i]); |
There was a problem hiding this comment.
this needs to be verified to be at the reference block number
gpsanant
reviewed
Dec 5, 2023
| @@ -168,10 +146,8 @@ contract BLSSignatureChecker is IBLSSignatureChecker { | |||
| require(pairingSuccessful, "BLSSignatureChecker.checkSignatures: pairing precompile call failed"); | |||
| require(signatureIsValid, "BLSSignatureChecker.checkSignatures: signature is invalid"); | |||
| } | |||
| // set signatoryRecordHash variable used for fraudproofs | |||
gpsanant
reviewed
Dec 5, 2023
| @@ -69,96 +69,74 @@ contract BLSSignatureChecker is IBLSSignatureChecker { | |||
| bytes32 | |||
| ) | |||
| { | |||
| // verify the provided apk was the apk at referenceBlockNumber | |||
| // loop through every quorumNumber and keep track of the apk | |||
| QuorumStakeTotals memory quorumStakeTotals; | |||
There was a problem hiding this comment.
do we have estimates of how much gas this saves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.