Feat ecdsa sigs #104
Closed
Feat ecdsa sigs #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
break up services into bls and ecdsa create ecdsa SignMsg function - more of a placeholder for now generated bindings for ecdsaSignatureChecker updated middleware contracts again (after rebasing on master) and updated bindings renamed bls/bls_aggregation -> bls/aggregation updated middleware contracts and generated bindings some updates to ecdsa types ecdsa avs registry service tests pass no more compilation errors - mocks generated - ecdsa agg tests still failing tests are passing
samlaf
force-pushed
the
feat-ecdsa-sigs
branch
from
805f12e to
15cfe65
Compare
samlaf
commented
Jan 29, 2024
crypto/ecdsa/ecdsa.go
Outdated
Comment on lines
10
to
17
| // SignMsg is a wrapper around geth's crypto.Sign function which adds 27 to the v value | ||
| // see https://github.com/ethereum/go-ethereum/issues/28757#issuecomment-1874525854 | ||
| // and https://twitter.com/pcaversaccio/status/1671488928262529031 | ||
| // Currently all of our contracts expect the v value to be 27 or 28, which is why we add it here. | ||
| // VerifySignature below thus subtracts 27 from the v value before verifying the signature. | ||
| // TODO(samlaf): if and when we figure out some avs contracts use the 0/1 v scheme, or the eip-155 scheme, | ||
| // then we should generalize this function to sign based on a scheme passed as argument. | ||
| func SignMsg(msg []byte, privateKey *ecdsa.PrivateKey) ([]byte, error) { |
There was a problem hiding this comment.
This is an issue that I'm unsure how to deal with, so arranged it like this for now, but if anyone has ideas on how to better deal with this, would be good to know.
|
Closing it because it is outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently developing ecdsa versions of everything:
Leaving this as a draft until I've finished incorporating these changes into the ecdsa version of inc-sq, but would still appreciate a review on the current structural decisions in this PR. Main things are: