Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rewards coordinator storage part2 #567

Merged
merged 5 commits into from
Feb 14, 2025
Merged

feat: Rewards coordinator storage part2 #567

merged 5 commits into from
Feb 14, 2025

Conversation

Sidu28
Copy link
Contributor

@Sidu28 Sidu28 commented Feb 13, 2025

Fixes # .

What Changed?

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@Sidu28 Sidu28 requested a review from MegaRedHand February 13, 2025 23:49
@Sidu28 Sidu28 marked this pull request as ready for review February 13, 2025 23:49
@Sidu28 Sidu28 changed the title Rewards coordinator storage part2 feat: Rewards coordinator storage part2 Feb 13, 2025
@Sidu28 Sidu28 mentioned this pull request Feb 14, 2025
Merged
3 tasks
MegaRedHand
MegaRedHand reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you regenerate the bindings? Since IRewardsCoordinator was removed from the Makefile, the bindings should be removed too.

@Sidu28
Copy link
Contributor Author

Sidu28 commented Feb 14, 2025

Can you regenerate the bindings? Since IRewardsCoordinator was removed from the Makefile, the bindings should be removed too.

@MegaRedHand removed unused bindings

@MegaRedHand MegaRedHand merged commit b921cbd into RewardsCoordinatorStorage Feb 14, 2025
9 checks passed
@MegaRedHand MegaRedHand deleted the RewardsCoordinatorStoragePart2 branch February 14, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sidu28 @MegaRedHand