Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new BLS aggregation service interface #578

Merged
merged 42 commits into from
Feb 19, 2025
Merged

feat: new BLS aggregation service interface #578

merged 42 commits into from
Feb 19, 2025

Conversation

maximopalopoli
Copy link
Contributor

@maximopalopoli maximopalopoli commented Feb 18, 2025 •
edited
Loading

What Changed?

This PR changes the bls aggregation service interface to simplify the user experience. The user now interacts with the service handler, receiving the aggregated responses via the Aggregate Receiver, instead of accessing to the service directly.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@maximopalopoli
Add start method and related structs
8b2bb0a
@maximopalopoli
Add run method handling both logics
bff34f4
@maximopalopoli
Add InitializeNewTask method for ServiceHandler
452f768
@maximopalopoli
Add processSignature function
eea1ec5
@maximopalopoli
implement ReceiveAggregatedResponse for AggregateReceiver
8d6afae
@maximopalopoli
Remove unused attributes at BlsAggregatorService struct
268cf9e
@maximopalopoli
Modify the service interface
e8d301a
@maximopalopoli
add agg responses channel to run function
956a9dc
@maximopalopoli
fix some lint alerts
dc174c7
@maximopalopoli
Change tests according to new interface
31dfdad
@maximopalopoli
fmt changes
0e6ff10
@maximopalopoli
Return error if task is not found
d1dc8f8
@maximopalopoli
Send an error in case the task was already initialized
e0818a2
@maximopalopoli
Add change and example to the changelog file
7b48e9d
@maximopalopoli
Remove commented code
f73ec10
@maximopalopoli
Add description for ProcessNewSignature fn
88c59f2
@maximopalopoli
Rename snake case named attribute
3e7cce1
@maximopalopoli
Add more function descriptions
827ccf2
@maximopalopoli
Remove err returned in start function
390a7dd
@maximopalopoli
Add changes to changelog
967c33e
@maximopalopoli
Add brief comment to start function in service interface
31c6aeb
@maximopalopoli
Remove unnecesary comments
5031a70
@maximopalopoli maximopalopoli marked this pull request as ready for review February 19, 2025 15:37
MegaRedHand
MegaRedHand reviewed Feb 19, 2025
View reviewed changes
MegaRedHand
MegaRedHand reviewed Feb 19, 2025
View reviewed changes
@MegaRedHand MegaRedHand changed the title refactor: bls aggregation service feat: new interface for bls aggregation service Feb 19, 2025
@MegaRedHand MegaRedHand changed the title feat: new interface for bls aggregation service feat: new BLS aggregation service interface Feb 19, 2025
MegaRedHand
MegaRedHand approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@MegaRedHand MegaRedHand added this pull request to the merge queue Feb 19, 2025
Merged via the queue into Layr-Labs:dev with commit 69e7d28 Feb 19, 2025
10 checks passed
@MegaRedHand MegaRedHand deleted the refactor/bls-aggregation-service branch February 19, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximopalopoli @MegaRedHand