fix: propagate DontUseAllocationManager flag between builders configs #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximopalopoli
changed the title
pablodeymo
approved these changes
Feb 20, 2025
MegaRedHand
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
The flag
DontUseAllocationManagerin config variables does not propagate between builders. This means that if a user of SDK sets this attribute as true in the config passed toBuildClientsfunction, then this flag is dismissed when creating new config files for creation of avsregistry and elcontracts readers and writers. This PRs changes this by setting those attributes with the value setted on config parameter.Reviewer Checklist