ci: add workflow to check bindings are up to date #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricomateo
added
the
pipelines
pablodeymo
reviewed
Jan 21, 2025
Co-authored-by: Pablo Deymonnaz <[email protected]>
pablodeymo
approved these changes
Jan 21, 2025
pablodeymo
approved these changes
Jan 21, 2025
MegaRedHand
pushed a commit
that referenced
this pull request
Feb 4, 2025
Fixes #207 This PR introduces the following changes * Adds a CI workflow to check if the bindings are up to date. This works by re-generating the bindings and checking the diff against the existing bindings. * Changes the `make bindings` target to generate the bindings using a specific Foundry version. This is important since different Foundry versions may generate slightly different bindings, which will cause the CI to fail. To ensure a specific Foundry version is used, we run the command inside a Docker container that runs a pinned Foundry version (v0.3.0). * Updates the bindings by generating them with the modified `make bindings` target. **Note:** the existing `bindings` target was renamed to `bindings_host`, as it runs without Docker. However the `bindings_host` target is only for CI use only. To generate the bindings, please use the `bindings` target. - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Pablo Deymonnaz <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207
What Changed?
This PR introduces the following changes
make bindingstarget to generate the bindings using a specific Foundry version. This is important since different Foundry versions may generate slightly different bindings, which will cause the CI to fail. To ensure a specific Foundry version is used, we run the command inside a Docker container that runs a pinned Foundry version (v0.3.0).make bindingstarget.Note: the existing
bindingstarget was renamed tobindings_host, as it runs without Docker. However thebindings_hosttarget is only for CI use only. To generate the bindings, please use thebindingstarget.Reviewer Checklist
changelog-Xlabels (if applies)