Merge branch 'master' into upgrade_to_eigen_sdk_0.1.12

.github/workflows/contracts-tests.yml

@@ -25,3 +25,8 @@ jobs:
       - name: Run tests
         run: forge test -vvv
         working-directory: ./contracts
+
+
+      - name: Enforce Formatting
+        run: forge fmt --check
+        working-directory: ./contracts

.github/workflows/daily-test.yaml

@@ -0,0 +1,36 @@
+name: Daily Build And Test Dev
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 0 * * *'
+jobs:
+  check:
+    strategy:
+      fail-fast: true
+    defaults:
+      run:
+        working-directory: ./contracts
+
+    name: Foundry project
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
+
+      - name: Install Foundry
+        uses: foundry-rs/foundry-toolchain@v1
+        with:
+          version: nightly
+
+      - name: Run Forge build
+        run: |
+          forge --version
+          forge build --sizes
+        id: build
+
+      - name: Run Forge tests
+        run: |
+          forge test -vvv
+        id: test

.github/workflows/storage-checker.yaml

@@ -0,0 +1,46 @@
+name: Check Storage Layout
+on:
+  pull_request:
+    branches:
+      - master
+jobs:
+  check_storage:
+    runs-on: "ubuntu-latest"
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
+      - name: Install Foundry
+        uses: foundry-rs/foundry-toolchain@v1
+        with:
+          version: nightly
+
+      - name: "Generate and prepare the contract artifacts"
+        run: |
+          cd contracts && mkdir pr
+          for file in $(find src -name '*.sol'); do
+              contract_name=$(basename "$file" .sol)
+              forge inspect "$contract_name" storage --pretty > pr/"$contract_name".md
+          done
+
+      - name: Checkout Base Branch
+        env:
+          BASE: ${{ github.event.pull_request.base.sha }}
+        run: |
+          git fetch origin $BASE
+          git checkout $BASE
+
+      - name: "Generate and prepare the contract artifacts"
+        run: |
+          cd contracts && mkdir base
+          for file in $(find src -name '*.sol'); do
+              contract_name=$(basename "$file" .sol)
+              forge inspect "$contract_name" storage --pretty > base/"$contract_name".md
+          done
+      - name: Compare outputs
+        run: |
+          if ! diff --unified contracts/pr contracts/base; then
+            # Note: We are only creating a warning because storage changes might be intentional but should be looked into
+            # reach out to steven if you see a warning on this workflow and need help validating if it is expected or not
+            echo "::warning::Differences found between PR and base storage layouts"
+          fi

README.md

@@ -18,6 +18,10 @@ You will also need to [install docker](https://docs.docker.com/get-docker/), and
 ```
 make build-contracts
 ```
+You will also need to [install abigen](https://geth.ethereum.org/docs/tools/abigen) if you want to make changes to the smart contracts and then generate the go bindings 
+```
+make bindings
+```
 
 ## Running via make
 
@@ -114,4 +118,4 @@ When running on anvil, a typical log for the operator is
 [2024-04-09 18:25:10.679 PDT] INFO (logging/zap_logger.go:49) Signed task response header accepted by aggregator. {"reply":false}
 ```
 
-The error `task 2 not initialized or already completed` is expected behavior. This is because the aggregator needs to setup its data structures before it can accept responses. But on a local anvil setup, the operator had time to receive the websocket event for the new task, square the number, sign the response, and send it to the aggregator process before the aggregator has finalized its setup. Hence, the operator retries sending the response 2 seconds later and it is accepted.
+The error `task 2 not initialized or already completed` is expected behavior. This is because the aggregator needs to setup its data structures before it can accept responses. But on a local anvil setup, the operator had time to receive the websocket event for the new task, square the number, sign the response, and send it to the aggregator process before the aggregator has finalized its setup. Hence, the operator retries sending the response 2 seconds later and it is accepted.

contracts/foundry.toml

@@ -2,7 +2,7 @@
 src = "src"
 out = "out"
 libs = ["lib"]
-fs_permissions = [{ access = "read-write", path = "./"}]
+fs_permissions = [{ access = "read-write", path = "./" }]
 
 remappings = [
     "@eigenlayer/=lib/eigenlayer-middleware/lib/eigenlayer-contracts/src/",
@@ -12,7 +12,7 @@ remappings = [
     "@openzeppelin/=lib/eigenlayer-middleware/lib/eigenlayer-contracts/lib/openzeppelin-contracts/",
     "@openzeppelin-upgrades/=lib/eigenlayer-middleware/lib/eigenlayer-contracts/lib/openzeppelin-contracts-upgradeable/",
     "forge-std/=lib/forge-std/src/",
-    "ds-test/=lib/forge-std/lib/ds-test/src/"
+    "ds-test/=lib/forge-std/lib/ds-test/src/",
 ]
 
 gas_reports = ["*"]
@@ -28,4 +28,13 @@ via_ir = false
 # Override the Solidity version (this overrides `auto_detect_solc`)
 solc_version = '0.8.12'
 
+[fmt]
+bracket_spacing = false
+int_types = "long"
+line_length = 100
+multiline_func_header = "params_first"
+number_underscore = "thousands"
+quote_style = "double"
+tab_width = 4
+
 # See more config options https://github.com/foundry-rs/foundry/tree/master/config