Skip to content

Rename events and functions to be more consistent #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 tasks done
LearningNerd opened this issue Jun 28, 2017 · 0 comments
Closed
5 tasks done

Rename events and functions to be more consistent #1

LearningNerd opened this issue Jun 28, 2017 · 0 comments
Labels
refactor
Milestone
Refactor and fix ...

Comments

@LearningNerd
Copy link
Member

LearningNerd commented Jun 28, 2017 •
edited
Loading

Tasks for this issue:

  • Rename editorChange or changeScroll and changeCursor for a consistent naming scheme!

  • Rename handleNewCursorData, handleNewScrollData, handleEditorChange, as well as handleChangeCursor, handleChangeScroll, and handleUserTyping functions! They should be more symmetrical!

    • Maybe something like handleLocal[EVENT] for local user input and handleServer[EVENT] for receiving the related SocketIO events?

  • Rename loggedIn event and handleUserLogin function to better match other names.

  • Rename createNewGist function to match other names.

  • Update changes in event list table and flowchart
LearningNerd added a commit that referenced this issue Jun 28, 2017
@LearningNerd
For #1: rename editor events
dd4d3d6 
  - editorChange --> editorTextChange
  - changeScroll --> editorScrollChange
  - changeCursor --> editorCursorChange
LearningNerd added a commit that referenced this issue Jun 28, 2017
@LearningNerd
For #1: rename client functions for editor events
a8fe678 
  - handleUserTyping	--> handleLocalEditorTextChange
  - handleNewCursorData	--> handleServerEditorTextChange

  - handleChangeScroll	--> handleLocalEditorScrollChange
  - handleNewScrollData	--> handleServerEditorScrollChange

  - handleChangeCursor	--> handleLocalEditorCursorChange
  - handleNewCursorData	--> handleServerEditorCursorChange
LearningNerd added a commit that referenced this issue Jun 28, 2017
@LearningNerd
For #1: rename loggedIn event, createNewGist function
5ed5588 
  - loggedIn --> userLogin
  - createNewGist --> handleCreateNewGist
@LearningNerd LearningNerd mentioned this issue Jun 28, 2017
Merged
LearningNerd added a commit that referenced this issue Jun 28, 2017
@LearningNerd
Merge pull request #13 from LearnTeachCode/issue1
180617a 
Rename functions, closes issue #1
@LearningNerd LearningNerd mentioned this issue Jun 28, 2017
Merged
LearningNerd added a commit that referenced this issue Jun 28, 2017
@LearningNerd
Merge pull request #19 from LearnTeachCode/issue1
86522d2 
Fixes cursor/selection bug caused by bad search-and-replace job in PR #13 for issue #1. Now all better!
@LearningNerd LearningNerd mentioned this issue Jun 29, 2017
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
Refactor and fix version 1.0.0
Development

No branches or pull requests
1 participant
@LearningNerd